check if shared_ciphers() is None before logging #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check for
None
return inssl.SSLSocket.shared_ciphers()
Background & Motivation
This is motivated by an observed exception in the PyKMIP server logs:
shared_ciphers
is documented as possibly returningNone
:Python 3.11.3 changed behavior of ssl.SSLSocket.shared_ciphers(). Which appears to result in
None
being returned in additional scenarios.