Fix Streamer/Recorder build errors #1158
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamer/Recorder toolbox was failing at build because since GCC 11, the default C++ standard is C++17, which does not allow dynamic exception specifications anymore. This was resolved by changing the C++ standard used to build the ProtonectSR target to C++14, though I suppose the ideal solution would be to simply not use dynamic exception specifications anymore.
There was also the problem that the files
recorder.cpp
andstreamer.cpp
referencedCV_IMWRITE_JPEG_QUALITY
when, at least according to what I could find, doesn't exist and should becv::IMWRITE_JPEG_QUALITY
.Resolves: #1155