Merge pull request #174 from OpenLMIS-Angola/ANGOLASUP-909

ANGOLASUP-909: resolving first request
OpenLMIS-Angola · Sep 2, 2024 · 5e14d44 · 5e14d44
2 parents 6c31ffa + edf85df
commit 5e14d44
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/stock-physical-inventory-draft/physical-inventory-draft.controller.js b/src/stock-physical-inventory-draft/physical-inventory-draft.controller.js
@@ -479,6 +479,13 @@
             });
         }
 
+        function setItemsWithUnit() {
+            var itemsWithUnit = draft.lineItems.filter(function(item) {
+                return item.unit;
+            });
+            draft.lineItems = itemsWithUnit;
+        }
+
         /**
          * @ngdoc method
          * @methodOf stock-physical-inventory-draft.controller:PhysicalInventoryDraftController
@@ -488,6 +495,7 @@
          * Save physical inventory draft.
          */
         vm.saveDraft = function(withNotification) {
+            setItemsWithUnit();
             multiplyUnitsByFactor(draft.lineItems);
             loadingModalService.open();
             return physicalInventoryFactory.saveDraft(draft).then(function() {
@@ -614,7 +622,7 @@
 
                     draft.occurredDate = resolvedData.occurredDate;
                     draft.signature = resolvedData.signature;
-
+                    setItemsWithUnit();
                     return saveLots(draft, function() {
                         physicalInventoryService.submitPhysicalInventory(draft).then(function() {
                             notificationService.success('stockPhysicalInventoryDraft.submitted');
@@ -888,10 +896,7 @@
 
         function getUnitById(unitId) {
             if (!unitId) {
-                return {
-                    name: '-',
-                    factor: 1
-                };
+                return undefined;
             }
 
             return vm.unitsOfOrderable.find(function(unit) {