-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAM-200: Delele orders #32
Conversation
(cherry picked from commit fd63632)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing CREATING-status check for Order deletion.
@sradziszewski do permissions have migration scripts?
Yes, if we want to check it this way, we need to add the ORDER_DELETE right using migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add migration with new right insertion.
Added rights here: OpenLMIS/openlmis-referencedata#105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still can't see how the 3rd AC is solved:
Orders must have the status CREATING in order to be eligible for deletion. Other statuses will not be accepted.
src/integration-test/java/org/openlmis/fulfillment/web/OrderControllerIntegrationTest.java
Show resolved
Hide resolved
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
(cherry picked from commit fd63632)