Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAM-200: Delele orders #32

Merged
merged 18 commits into from
Jun 18, 2024
Merged

OAM-200: Delele orders #32

merged 18 commits into from
Jun 18, 2024

Conversation

tsznaj
Copy link
Contributor

@tsznaj tsznaj commented Jun 17, 2024

(cherry picked from commit fd63632)

Copy link
Contributor

@pwargulak pwargulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing CREATING-status check for Order deletion.

@sradziszewski do permissions have migration scripts?

@sradziszewski
Copy link
Contributor

I'm missing CREATING-status check for Order deletion.

@sradziszewski do permissions have migration scripts?

Yes, if we want to check it this way, we need to add the ORDER_DELETE right using migration.

Copy link
Contributor

@sradziszewski sradziszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add migration with new right insertion.

@tsznaj
Copy link
Contributor Author

tsznaj commented Jun 17, 2024

Added rights here: OpenLMIS/openlmis-referencedata#105

Copy link
Contributor

@pwargulak pwargulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can't see how the 3rd AC is solved:

Orders must have the status CREATING in order to be eligible for deletion. Other statuses will not be accepted.

@tsznaj tsznaj merged commit 1bd60f6 into rel-9.0.5-angola.X Jun 18, 2024
1 of 2 checks passed
@tsznaj tsznaj deleted the OAM-200 branch June 18, 2024 10:27
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
57.4% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants