Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAM-200: Added container for request body due to problems with array … #33

Merged
merged 5 commits into from
Jun 20, 2024
Merged

OAM-200: Added container for request body due to problems with array … #33

merged 5 commits into from
Jun 20, 2024

Conversation

tsznaj
Copy link
Contributor

@tsznaj tsznaj commented Jun 19, 2024

…in body.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@tsznaj
Copy link
Contributor Author

tsznaj commented Jun 20, 2024

https://sonarcloud.io/component_measures?metric=new_coverage&selected=OpenLMIS_openlmis-fulfillment%3Asrc%2Fmain%2Fjava%2Forg%2Fopenlmis%2Ffulfillment%2Fweb%2Futil%2FIdsDto.java&view=list&pullRequest=33&id=OpenLMIS_openlmis-fulfillment

I think there is no better example that we need excludes or loose some Sonarlint rules. :)

@tsznaj
Copy link
Contributor Author

tsznaj commented Jun 20, 2024

SonarLint points to some Lombok annotations for coverage tests.

@tsznaj tsznaj merged commit 4898283 into rel-9.0.5-angola.X Jun 20, 2024
2 of 3 checks passed
@tsznaj tsznaj deleted the OAM-200 branch June 20, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradziszewski sradziszewski sradziszewski approved these changes

@pwargulak pwargulak Awaiting requested review from pwargulak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsznaj @sradziszewski