Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAM-91: Fixes #53

Merged
merged 5 commits into from
Jun 11, 2024
Merged

OAM-91: Fixes #53

merged 5 commits into from
Jun 11, 2024

Conversation

tsznaj
Copy link
Contributor

@tsznaj tsznaj commented Jun 10, 2024

No description provided.

@tsznaj tsznaj changed the base branch from master to rel-5.1.10-angola.X June 10, 2024 12:13
Copy link
Contributor

@sradziszewski sradziszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I have a question - where is this UnitOfOrderableValidator used?

@tsznaj
Copy link
Contributor Author

tsznaj commented Jun 10, 2024

Good point! This should be corrected!

@tsznaj
Copy link
Contributor Author

tsznaj commented Jun 10, 2024

With the failing tests as well.

Copy link

sonarcloud bot commented Jun 11, 2024

@tsznaj
Copy link
Contributor Author

tsznaj commented Jun 11, 2024

@sradziszewski please check again - if ok, please approve and merge.

Copy link
Contributor

@sradziszewski sradziszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@sradziszewski sradziszewski merged commit e497730 into rel-5.1.10-angola.X Jun 11, 2024
3 checks passed
@tsznaj tsznaj deleted the OAM-91-fixes branch June 11, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants