OAM-218: Updated programId param to repeatable #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsznaj
requested changes
Jun 26, 2024
...t/java/org/openlmis/stockmanagement/web/ValidSourceDestinationControllerIntegrationTest.java
Outdated
Show resolved
Hide resolved
.../stockmanagement/web/stockcardsummariesv2/StockCardSummariesV2ControllerIntegrationTest.java
Outdated
Show resolved
Hide resolved
...main/java/org/openlmis/stockmanagement/repository/SourceDestinationAssignmentRepository.java
Outdated
Show resolved
Hide resolved
...main/java/org/openlmis/stockmanagement/repository/SourceDestinationAssignmentRepository.java
Outdated
Show resolved
Hide resolved
...main/java/org/openlmis/stockmanagement/repository/SourceDestinationAssignmentRepository.java
Show resolved
Hide resolved
src/main/java/org/openlmis/stockmanagement/web/ValidReasonAssignmentSearchParams.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openlmis/stockmanagement/web/ValidSourceDestinationSearchParams.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openlmis/stockmanagement/web/ValidSourceDestinationSearchParams.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openlmis/stockmanagement/web/ValidReasonAssignmentSearchParams.java
Outdated
Show resolved
Hide resolved
...java/org/openlmis/stockmanagement/testutils/StockCardSummariesV2SearchParamsDataBuilder.java
Outdated
Show resolved
Hide resolved
tsznaj
reviewed
Jun 26, 2024
...org/openlmis/stockmanagement/repository/custom/impl/ValidReasonAssignmentRepositoryImpl.java
Outdated
Show resolved
Hide resolved
tsznaj
reviewed
Jun 26, 2024
src/main/java/org/openlmis/stockmanagement/web/ValidReasonAssignmentSearchParams.java
Outdated
Show resolved
Hide resolved
|
tsznaj
pushed a commit
that referenced
this pull request
Jul 2, 2024
OAM-218: Updated programId param to repeatable (#60) * OAM-218: WIP * OAM-218: Updated programId param to repeatable * OAM-218: Removed unused import, provided constants * OAM-218: Removed unnecessary stubbings * OAM-218: Added extra tests * OAM-218: Provided changes after review * OAM-218: Removed 'Ignore' annotation * OAM-218: Added extra condition to test * OAM-218: Fixed params/method names * OAM-218: Added tests for coverage. --------- Co-authored-by: Piotr Wargulak <[email protected]> Co-authored-by: tsznaj <[email protected]> # Conflicts: # src/integration-test/java/org/openlmis/stockmanagement/web/ValidSourceDestinationControllerIntegrationTest.java # src/main/java/org/openlmis/stockmanagement/repository/SourceDestinationAssignmentRepository.java # src/main/java/org/openlmis/stockmanagement/service/SourceDestinationBaseService.java # src/main/java/org/openlmis/stockmanagement/service/StockCardSummariesService.java # src/main/java/org/openlmis/stockmanagement/service/ValidDestinationService.java # src/main/java/org/openlmis/stockmanagement/service/ValidSourceService.java # src/main/java/org/openlmis/stockmanagement/validators/SourceDestinationGeoLevelAffinityValidator.java # src/main/java/org/openlmis/stockmanagement/web/ValidSourceDestinationController.java # src/test/java/org/openlmis/stockmanagement/service/SourceDestinationBaseServiceTest.java # src/test/java/org/openlmis/stockmanagement/validators/SourceDestinationGeoLevelAffinityValidatorTest.java
mgrochalskisoldevelo
pushed a commit
that referenced
this pull request
Jul 10, 2024
…ion logging performance better. (#61) * Cherry-pick (modified) from OAM-218 solution, commit 8b82790. OAM-218: Updated programId param to repeatable (#60) * OAM-218: WIP * OAM-218: Updated programId param to repeatable * OAM-218: Removed unused import, provided constants * OAM-218: Removed unnecessary stubbings * OAM-218: Added extra tests * OAM-218: Provided changes after review * OAM-218: Removed 'Ignore' annotation * OAM-218: Added extra condition to test * OAM-218: Fixed params/method names * OAM-218: Added tests for coverage. --------- Co-authored-by: Piotr Wargulak <[email protected]> Co-authored-by: tsznaj <[email protected]> # Conflicts: # src/integration-test/java/org/openlmis/stockmanagement/web/ValidSourceDestinationControllerIntegrationTest.java # src/main/java/org/openlmis/stockmanagement/repository/SourceDestinationAssignmentRepository.java # src/main/java/org/openlmis/stockmanagement/service/SourceDestinationBaseService.java # src/main/java/org/openlmis/stockmanagement/service/StockCardSummariesService.java # src/main/java/org/openlmis/stockmanagement/service/ValidDestinationService.java # src/main/java/org/openlmis/stockmanagement/service/ValidSourceService.java # src/main/java/org/openlmis/stockmanagement/validators/SourceDestinationGeoLevelAffinityValidator.java # src/main/java/org/openlmis/stockmanagement/web/ValidSourceDestinationController.java # src/test/java/org/openlmis/stockmanagement/service/SourceDestinationBaseServiceTest.java # src/test/java/org/openlmis/stockmanagement/validators/SourceDestinationGeoLevelAffinityValidatorTest.java * OLMIS-7953: coverage test * OLMIS-7953: moved to impl subdirectories * OLMIS-7953: little changes to omit unnecessary coverage tests * OLMIS-7953: added coverage test --------- Co-authored-by: Szymon Radziszewski <[email protected]>
khobatha
pushed a commit
to Lesotho-eLMIS/lesotho-stockmanagement
that referenced
this pull request
Jul 25, 2024
…ion logging performance better. (OpenLMIS#61) * Cherry-pick (modified) from OAM-218 solution, commit 8b82790. OAM-218: Updated programId param to repeatable (OpenLMIS#60) * OAM-218: WIP * OAM-218: Updated programId param to repeatable * OAM-218: Removed unused import, provided constants * OAM-218: Removed unnecessary stubbings * OAM-218: Added extra tests * OAM-218: Provided changes after review * OAM-218: Removed 'Ignore' annotation * OAM-218: Added extra condition to test * OAM-218: Fixed params/method names * OAM-218: Added tests for coverage. --------- Co-authored-by: Piotr Wargulak <[email protected]> Co-authored-by: tsznaj <[email protected]> # Conflicts: # src/integration-test/java/org/openlmis/stockmanagement/web/ValidSourceDestinationControllerIntegrationTest.java # src/main/java/org/openlmis/stockmanagement/repository/SourceDestinationAssignmentRepository.java # src/main/java/org/openlmis/stockmanagement/service/SourceDestinationBaseService.java # src/main/java/org/openlmis/stockmanagement/service/StockCardSummariesService.java # src/main/java/org/openlmis/stockmanagement/service/ValidDestinationService.java # src/main/java/org/openlmis/stockmanagement/service/ValidSourceService.java # src/main/java/org/openlmis/stockmanagement/validators/SourceDestinationGeoLevelAffinityValidator.java # src/main/java/org/openlmis/stockmanagement/web/ValidSourceDestinationController.java # src/test/java/org/openlmis/stockmanagement/service/SourceDestinationBaseServiceTest.java # src/test/java/org/openlmis/stockmanagement/validators/SourceDestinationGeoLevelAffinityValidatorTest.java * OLMIS-7953: coverage test * OLMIS-7953: moved to impl subdirectories * OLMIS-7953: little changes to omit unnecessary coverage tests * OLMIS-7953: added coverage test --------- Co-authored-by: Szymon Radziszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA task link: https://openlmis.atlassian.net/browse/OAM-218