Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLMIS-7952: Copied and adjusted solutions for 2nd approval for requisition to make application logging performance better, commits: 6da4960 and 87e17c9. #63

Merged
merged 8 commits into from
Jul 9, 2024

Conversation

tsznaj
Copy link
Contributor

@tsznaj tsznaj commented Jul 8, 2024

OLMIS-7952: Copied and adjusted solutions for 2nd approval for requisition to make application logging performance better, commits: 6da4960 and 87e17c9.

Copy link
Contributor

@sradziszewski sradziszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comment

Copy link

sonarcloud bot commented Jul 9, 2024

@tsznaj tsznaj merged commit 37f3d27 into master Jul 9, 2024
3 checks passed
@tsznaj tsznaj deleted the OLMIS-7952 branch July 9, 2024 15:09
khobatha pushed a commit to Lesotho-eLMIS/lesotho-stockmanagement that referenced this pull request Jul 25, 2024
…ition to make application logging performance better, commits: 6da4960 and 87e17c9. (OpenLMIS#63)

* OLMIS-7952: Copied and adjusted solutions for 2nd approval for requisition to make application logging performance better, commits: 6da4960 and 87e17c9.

* OLMIS-7952: Removed TODO.

* OLMIS-7952: Style corrections.

* OLMIS-7952: Added integration testing when building.

* OLMIS-7952: Fixed indentations.

* OLMIS-7952: Added test coverage and corrected method description.

* OLMIS-7952: Added another test coverage.

* OLMIS-7952: Added another test coverage.

---------

Co-authored-by: pwargulak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants