Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated the code base to manifest v3 #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Migrated the code base to manifest v3 #7

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41634a5
Migrated the code the manifest V3
adismort14 Oct 16, 2022
2ede249
worker-wrapper.js file
adismort14 Oct 16, 2022
7f3c0cf
Merge branch 'OpenLake:master' into manifest_v3
adismort14 Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const gradesPageRule = {
},
}),
],
actions: [new browser.declarativeContent.ShowPageAction()],
actions: [new browser.declarativeContent.ShowAction()],
};

browser.runtime.onInstalled.addListener(function () {
Expand Down
4 changes: 2 additions & 2 deletions browser-polyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@
"maxArgs": 2
}
},
"pageAction": {
"Action": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying this file is less than ideal because this is library code. The polyfill does not support MV3.
Moreover, it might not be needed anymore since chrome now supports many promise based APIs.
Try replacing this file with:

const global = typeof globalThis !== 'undefined' ? globalThis : typeof self !== 'undefined' ? self : this
global.browser = typeof browser === 'undefined' ? chrome : browser

"getPopup": {
"minArgs": 1,
"maxArgs": 1
Expand Down Expand Up @@ -1235,4 +1235,4 @@
module.exports = browser;
}
});
//# sourceMappingURL=browser-polyfill.js.map
// sourceMappingURL=browser-polyfill.js.map
9 changes: 4 additions & 5 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "IITBh CGPA",
"version": "2.3",
"version": "2.4",
"description": "Calculate CGPA directly from AIMS Portal. Click on the extension logo when on AIMS portal's courses page to see your CGPA.",
"permissions": ["activeTab", "declarativeContent"],
"page_action": {
"action": {
"default_popup": "popup.html",
"show_matches": [
"*://aimsportal.iitbhilai.ac.in/iitbhAims/courseReg/myCrsHistoryPage*"
Expand All @@ -16,8 +16,7 @@
"default_title": "CGPA"
},
"background": {
"scripts": ["browser-polyfill.js", "background.js"],
"persistent": false
"service_worker": "worker-wrapper.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox MV3 is currently in beta and does not support background service worker.
Lets wait for merging this. We can merge this when firefox supports this.
If that does not happen before chrome ends mv2 support, we can create a script to generate 2 different manifest files.

},
"content_scripts": [
{
Expand All @@ -32,5 +31,5 @@
"32": "images/32x32.png",
"128": "images/128x128.png"
},
"manifest_version": 2
"manifest_version": 3
}
5 changes: 5 additions & 0 deletions worker-wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
try {
importScripts("browser-polyfill.js", "background.js");
} catch (e) {
console.log(e);
}