Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages related to running tests when skipTests is set to true #447

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update messages related to running tests when skipTests is set to true #447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c8fddf
Update messages related to running tests when skipTests is set to true
cherylking Jul 15, 2024
409d413
review comment
cherylking Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,12 @@ public void runTests(boolean waitForApplicationUpdate, int messageOccurrences, T
error(e.getMessage(), e);
}
}
} else {
cherylking marked this conversation as resolved.
Show resolved Hide resolved
if (projectName != null) {
info("Tests will not run on demand for " + projectName + " because skipTests is set to true.");
} else {
info("Tests will not run on demand because skipTests is set to true.");
}
}
}

Expand Down Expand Up @@ -2522,6 +2528,10 @@ private void printDevModeMessages(boolean inputUnavailable, boolean startup) thr
}

private void printTestsMessage(boolean formatForAttention) {
// setting skipTests to true overrides the setting of hotTests, and prevents any tests from running in dev mode (automatically or on demand)
if (skipTests) {
return;
}
if (hotTests) {
String message = "Tests will run automatically when changes are detected. You can also press the Enter key to run tests on demand.";
info(formatForAttention ? formatAttentionMessage("Enter - " + message) : message);
Expand Down
Loading