Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versionless feature 1.0 (#296) #297

Closed
wants to merge 2 commits into from
Closed

Versionless feature 1.0 (#296) #297

wants to merge 2 commits into from

Conversation

arunvenmany-ibm
Copy link
Contributor

@arunvenmany-ibm arunvenmany-ibm commented Aug 21, 2024 •
edited
Loading

  • Versionless feature changes. Added platform component

    1. updated xsd, featurelist xml and features.json to 24.0.0.8
    2. added completion to show all platforms

  • Versionless feature changes. Added hover for platform components

    1. Added description for platform

  • platform diagnostic scenarios

    1. check for platform validity
    2. check for platform uniqueness
    3. check for conflicting platforms( ie, platforms j2ee and jakartaee should not be used together

  • Versioned feature and platform validation diagnostics

    1. if platforms are already included and its not matching with the platforms specified in versioned features, show diagnostic

  • Version less feature and platform validation diagnostics

    1. if platforms is not included and no versioned feature is included and versionless feature is included, then show diagnostic
    2. if platforms are included and only versionless feature included, check for common platforms for versionless feature and match with selected platform. If not matching, throw error
    3. if platforms are included and both versioned and versionless features are added, check for common platform from versionless feature, versioned feature and match with platforms

@arunvenmany-ibm
Versionless feature 1.0 (#296)
7f6375b 
* Versionless feature changes. Added platform component

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. Added hover for platform component

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. modified diagnostics

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. modified diagnostics

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. adding more diagnostic scenarios

Signed-off-by: Arun Venmany <[email protected]>

---------

Signed-off-by: Arun Venmany <[email protected]>
cherylking
cherylking requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed everything except the LibertyDiagnosticParticipant and the LibertyDiagnosticTest. I am going to take a break now and come back to it later. Overall it looks very good and a lot of my comments are minor.

...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java Show resolved Hide resolved
...x-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/services/FeatureService.java Outdated Show resolved Hide resolved
...inx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyConstants.java Outdated Show resolved Hide resolved
lemminx-liberty/src/test/java/io/openliberty/LibertyCompletionTest.java Show resolved Hide resolved
lemminx-liberty/src/test/java/io/openliberty/LibertyHoverTest.java Show resolved Hide resolved
lemminx-liberty/src/test/java/io/openliberty/LibertyCompletionTest.java Show resolved Hide resolved
cherylking
cherylking requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the LibertyDiagnosticTest and some of LibertyDiagnosticParticipant. But until I get clarification from Chuck on whether they can specify both versioned features and platform elements at the same time, I don't want to make more comments.

lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java Outdated Show resolved Hide resolved
lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java Outdated Show resolved Hide resolved
lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java Outdated Show resolved Hide resolved
lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java Outdated
Diagnostic invalid5 = new Diagnostic();
invalid5.setRange(r(2, 24, 2, 33));
invalid5.setCode(LibertyDiagnosticParticipant.INCORRECT_FEATURE_CODE);
invalid5.setMessage("ERROR: \"batch-1.0\" cannot be used since selected platform(s) [javaee-7.0, javaee-8.0, jakartaee-9.1] do not match with supported platform(s) [javaee-7.0, javaee-8.0]");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check with Chuck on this one, but we are supposed to use the platform to resolve the version for the versionless features...not really the versioned features. There is no versionless feature in this list. I don't think we want to flag this diagnostic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. I was under the assumption that if

  1. multiple versioned features are provided and if there is no common platform , then throw error
  2. versionless and are provided, but no common platform , then throw error
  3. versionless and versioned and are provided and no common platform , throw error

If above 3 cases are expected, then I think the scenario of multiple versioned features and is provided, then there should be a check for common platform

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not validate the versioned features with the specified <platform> elements. This diagnostic should be removed.

lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java Show resolved Hide resolved
@arunvenmany-ibm
Versionless feature 1.0 (#298)
ab3320b 
* Versionless feature changes. Added platform component

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. Added hover for platform component

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. modified diagnostics

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. modified diagnostics

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. adding more diagnostic scenarios

Signed-off-by: Arun Venmany <[email protected]>

* Versionless feature changes. code changes based on review comments

Signed-off-by: Arun Venmany <[email protected]>

---------

Signed-off-by: Arun Venmany <[email protected]>
@arunvenmany-ibm arunvenmany-ibm deleted the versionless_feature_1.0 branch October 24, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunvenmany-ibm @cherylking