Var processing #323
Merged
Var processing #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arunvenmany-ibm
commented
Dec 2, 2024
arunvenmany-ibm
commented
- Code Completion for variables on attribute value fields in server.xml
- Hover on variable in server.xml to see variable value
- Show diagnostics in server.xml for invalid variable names
- Show code completion for invalid variable diagnostics
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
…in branch Signed-off-by: Arun Venmany <[email protected]>
…ited Signed-off-by: Arun Venmany <[email protected]>
…t dev mode is not run Signed-off-by: Arun Venmany <[email protected]>
cherylking
requested changes
Dec 4, 2024
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...x-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyHoverParticipant.java
Outdated
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyUtils.java
Outdated
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyUtils.java
Outdated
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyUtils.java
Outdated
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
cherylking
requested changes
Dec 5, 2024
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...x-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyHoverParticipant.java
Outdated
Show resolved
Hide resolved
...-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/services/SettingsService.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/services/SettingsService.java
Outdated
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyUtils.java
Outdated
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyUtils.java
Outdated
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/LibertyUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <[email protected]>
cherylking
approved these changes
Dec 6, 2024
|
Opened issue #324 to follow up on variable completion logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.