Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intelij: 2024.2 Investigation of Test Automation Changes in the Action Menu After Migration to Gradle IntelliJ Plugin 2.* and Modifications in runIdeForUiTests #1018

Open
2 tasks
vaisakhkannan opened this issue Oct 15, 2024 · 8 comments
Assignees
Milestone

Comments

@vaisakhkannan
Copy link
Contributor

vaisakhkannan commented Oct 15, 2024

I noticed a change in the Action Menu bar after migrating to the Gradle IntelliJ Plugin 2.* and modifying the runIdeForUiTests.

A screenshot of the Action Menu bar after these changes is shown below,

Screenshot 2024-10-15 at 12 43 06 PM

Screenshot of the Action Menu bar based on the current main code UI test.

Screenshot 2024-10-15 at 12 14 56 PM
@vaisakhkannan vaisakhkannan changed the title Investigation of Test Automation Changes in the Action Menu After Migration to Gradle IntelliJ Plugin 2.* and Modifications in runIdeForUiTests Intel: 2024.2 Investigation of Test Automation Changes in the Action Menu After Migration to Gradle IntelliJ Plugin 2.* and Modifications in runIdeForUiTests Oct 15, 2024
@vaisakhkannan vaisakhkannan changed the title Intel: 2024.2 Investigation of Test Automation Changes in the Action Menu After Migration to Gradle IntelliJ Plugin 2.* and Modifications in runIdeForUiTests Intelij: 2024.2 Investigation of Test Automation Changes in the Action Menu After Migration to Gradle IntelliJ Plugin 2.* and Modifications in runIdeForUiTests Oct 15, 2024
@vaisakhkannan vaisakhkannan self-assigned this Oct 16, 2024
@vaisakhkannan vaisakhkannan moved this from New Issues to In Progress in Open Liberty Developer Experience Oct 16, 2024
@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Oct 16, 2024

As part of the investigation, I had a chat in the JetBrains Slack channel. Here is the link https://jetbrains-platform.slack.com/archives/C026SVA9MMM/p1729077907382179

As mentioned in the Slack channel, the classic UI has been removed starting from version 2024.2. Users who need the classic UI in 2024.2 will need to install a separate plugin called Classic UI.

I think we have two scenarios:

  1. Update the Automation Tests: We can update the automation tests to support version 2024.2 and remove support for 2024.1 in the upcoming release. We'll also try to support 2024.3, allowing us to cover a total of two versions.

  2. Add the Classic UI Plugin as a Dependency: We could add the Classic UI plugin as a dependency, similar to lsp4ij. However, the Classic UI plugin only supports versions from 2024.2 onwards, so we won’t be able to support 2024.1. Alternatively, we could implement a condition to detect the IntelliJ version before installing the plugin (though I’m not sure if this is feasible).

@TrevCraw What are your thoughts?

@TrevCraw
Copy link
Contributor

TrevCraw commented Oct 16, 2024

Thank you @vaisakhkannan. My initial thoughts are that we should not let test automation dictate our support in production. Just because we move to a new UI for the test automation does not mean we cannot support the old UI with our plugin. It is probably best to move forward with the new UI for our test automation.

@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Oct 28, 2024

There is one behavioral difference between Windows and Mac in the new UI for supporting IntelliJ 2024.2

Windows bebaviour

difference_in-windows.mp4

Mac behaviour

Screen.Recording.2024-10-28.at.2.13.14.PM.mov

I think we should check the conditions to determine which OS is running the UI test. Based on that, we should execute the tests. I also need to check the UI changes on Linux.

@turkeylurkey
Copy link
Member

If we're doing File > Save All does this matter?

@vaisakhkannan
Copy link
Contributor Author

If we're doing File > Save All does this matter?

@turkeylurkey , Do you mean a double shift action?

Screenshot 2024-10-28 at 8 28 07 PM

@turkeylurkey
Copy link
Member

No, I'm talking about 'find menu called "File", find menu item called "Save All" and click it.'

@vaisakhkannan
Copy link
Contributor Author

Ok, Yes @turkeylurkey , in that scenario, we can see the change in the menu bar. In Windows, if we click on the three lines, we get all menus displayed horizontally. However, in Mac, clicking on the three lines shows the menus as list items. So, if we click on 'File,' we should check the other menu items in the popup box that appears.

@vaisakhkannan
Copy link
Contributor Author

I checked the UI behavior on Linux today, and the behavior is the same as on Windows, so we can use the same common code for both Windows and Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants