-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intellij 2024.2: Investigation of Changes Needed to Support Java 21 #1019
Comments
Hi @TrevCraw, this is where we found that the source compatibility for intellij version 2024.2 should be 21. staicymathew@staicys-mbp liberty-tools-intellij2 % ./gradlew buildPlugin
https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html#platformVersions |
Regarding Java versions, as long as we are not using Java 21 features, we may be able to build against Java 21 and run on Java 17. Or, if that is not best practice, it may be possible to build with Java 17 and run on Java 21. I will defer to @mrglavas for the best way to achieve multiple levels of JVM support. Regardless of the strategy, we will need to test it out. We should be able to find a way to support both 2024.1 and 2024.2. According to the JetBrains marketplace, Quarkus Tools supports both 2024.1 and 2024.2 - https://plugins.jetbrains.com/plugin/13234-quarkus-tools/versions. I do not see Quarkus Tools using Java 21 in their build file - https://github.com/redhat-developer/intellij-quarkus/blob/main/build.gradle.kts#L133-L139. I would recommend trying out Quarkus Tools on 2024.2. Maybe you can find other example plugins that support 2024.1 and 2024.2 and see how they do it? |
Hi @mrglavas , I am not sure of the best practice regarding supporting multiple Java versions with one build, but I am wondering if it is even achievable based on how the IntelliJ ecosystem is set up. |
Hi @staicy123, @vaisakhkannan, after a discussion with @mrglavas and @turkeylurkey, it is recommended that we do not build with Java 21 and run on Java 17, as there are potential negative side effects. It should be safe, however, to build with Java 17 and run on Java 21. In order to do that, we need to do a few things:
|
Hi @TrevCraw, please find the discussion with jetbrains team regarding using java 17 here https://jetbrains-platform.slack.com/archives/C5U8BM1MK/p1729162829013169 |
Hi @TrevCraw, I checked the Quarkus Tools plugin code, cloned it, and ran the extension and UI tests. I found that both the extension IDE and UI test IDE are running on IntelliJ version 2023.2, but they also support IntelliJ 2024.2. I was able to install the Quarkus Tools plugin in IntelliJ 2024.2. The reason they did not specify the |
Our intention is to support both IntelliJ 2024.1 and 2024.2, so we have decided to set the common Java version to 17. However, we have also verified that we can support Java version 21 in IntelliJ 2024.2. Therefore, we will be closing this issue. |
As part of supporting IntelliJ
2024.2
, we need to support Java version21
. During the investigation, we found that our development environment should also run on theJava 21 SDK
. Therefore, we need to update the Java version to 21 for the sample projects used in test automation.The text was updated successfully, but these errors were encountered: