Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled developer to input PR number for lsp4ij checkout input #1014
base: main
Are you sure you want to change the base?
Enabled developer to input PR number for lsp4ij checkout input #1014
Changes from 6 commits
d8b3fb1
268fef1
642a146
71b7b45
ff9d671
ac37b47
606dac1
d8e796f
299ee2d
ba8e58b
ca1d44d
2b90902
4337bf3
1557623
b2972e4
4b37821
d551cda
ab59fb2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have code in cronJob.yaml to extract the merge commit SHA. Is there any way that we can re-use that code somehow instead of re-doing it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrevCraw , I tried investigating ways to reuse code from the
cronJob.yaml
file. We only require a specific portion of the code of thefetch_all_pull_request_shas
job, and we do not need the complete job or the other three jobs. During my investigation, I found the following:GitHub Actions does not support reusing a single job or some portion of a job from one workflow in another. Instead, we can achieve this by creating a new reusable workflow file that includes only the specific job(s) we want to reuse, but we can't create a common code for both the jobs that is, we use different values are being passed in the jobs, such as
checkout_name
in thefetch_merge_commit_sha_from_lsp4ij_PR
job (frombuild.yaml
) andis_empty
in thefetch_all_pull_request_shas
job. Thepr_details
variable is common to both jobs but has different values in each case.If you think to use the code written in the 'Extract Merge Commit SHA' step in an additional workflow file, we should pass the values of
${{ env.REF_LSP4IJ }}
and${{ env.LSP4IJ_BRANCH }}
as inputs to the new workflow file. Similarly, we need to get$pr_details
and$checkout_name
as outputs from the new workflow file, which will result in one additional build beyond the builds listed below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the image to show the new text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the image with the same name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to update the other images in the doc where the inputs for running the build.yaml are shown. I think there are two other places in this doc. Check the other doc files as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrevCraw, I updated the other images in the document and checked the other document files as well, but I couldn't find any images showing the inputs for running the build.yaml.