Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor methods in AbstractDiagnosticsCollector #1064

Conversation

dessina-devasia
Copy link
Contributor

@dessina-devasia dessina-devasia commented Oct 30, 2024

Fixes #1025

Refactor methods in AbstractDiagnosticsCollector for performance optimisation

@dessina-devasia dessina-devasia changed the title Refactor methods in AbstractF Refactor methods in AbstractDiagnosticsCollector Oct 30, 2024
@turkeylurkey turkeylurkey requested a review from mrglavas October 30, 2024 13:52
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments here: #1025 (comment)

@dessina-devasia
Copy link
Contributor Author

#1025 (comment)
Sure @mrglavas. Based on the comments, I've raised another PR. Closing the PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractDiagnosticsCollector: Investigate and resolve issues with matching qualified names.
2 participants