-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automation test to ensure no diagnostics shown for incorrect import or annotation similar to exact one corresponding to AnnotationDiagnosticsCollector #1085
Open
dessina-devasia
wants to merge
11
commits into
OpenLiberty:main
Choose a base branch
from
dessina-devasia:add-non-matching-test-annotation-diagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… annotations or import of PostConstruct Annotation
…n-test-post-construct Modification to ensure no diagnostics are generated for any incorrect annotations or import of PostConstruct Annotation
…rated-annotation Modification to ensure no incorrect import or annotation in Generated Annotation
…urce-annotation Modification to ensure no incorrect import or annotation in Resource Annotation
…estroy-annotation Modification to ensure no incorrect import or annotation in PreDestroy Annotation
vaisakhkannan
requested changes
Nov 8, 2024
...rc/main/java/io/openliberty/sample/jakarta/annotations/IncorrectPostConstructAnnotation.java
Show resolved
Hide resolved
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1025
Added automation test to ensure no diagnostics shown for incorrect import or annotation similar to exact one corresponding to AnnotationDiagnosticsCollector