Add constants for string literals in UI test classes #1199
+138
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusreelakshmi934
requested review from
aparnamichael,
staicy123 and
vaisakhkannan
vaisakhkannan
requested changes
Dec 19, 2024
src/main/java/io/openliberty/tools/intellij/util/Constants.java
Outdated
Show resolved
Hide resolved
vaisakhkannan
requested changes
Dec 19, 2024
| @@ -541,7 +542,7 @@ public static boolean isServerStopNeeded(String wlpInstallPath) { | |||
| */ | |||
| public static void checkDebugPort(String absoluteWLPPath, int debugPort) throws IOException { | |||
| // Retrieve the WLP server.env file path | |||
| Path serverEnvPath = Paths.get(absoluteWLPPath, "wlp", "usr", "servers", "defaultServer", "server.env"); | |||
| Path serverEnvPath = Paths.get(absoluteWLPPath, "wlp", "usr", "servers", "defaultServer", ItConstants.SERVER_ENV); | |||
There was a problem hiding this comment.
@TrevCraw , Do we need to consider adding all those strings, such as 'wlp', 'usr', 'servers', etc., to the ITConstants class? if not then we can keep "server.env" here instead of ItConstants.SERVER_ENV
Changed the Copyright year |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1153