-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to EE 11 only and promote dataContainer-1.0 to beta #28816
Switch to EE 11 only and promote dataContainer-1.0 to beta #28816
Conversation
#build |
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LuY_oS5pEe-0jrtdBgI-wg Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1cdd94ac-2fac-4caf-b37e-022741dc684f Target locations of links might be accessible only to IBM employees. |
The build failed. I forgot to update the Jakarta Data TCK bucket for EE 11. Trying again after updating... |
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/__WeQoC58Ee-0jrtdBgI-wg Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=2228d286-599e-4e6a-84bb-0f1c4099b3de Target locations of links might be accessible only to IBM employees. |
The build njr-11-28816-20240619-1456 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=__WeQoC58Ee-0jrtdBgI-wg |
Make sure that you update JakartaEE10Action to remove data-1.0 and check the EE Compatibility tests for anything special they might do. |
46e8c08
to
e4b76be
Compare
Thanks, I missed that and it turned out to be the cause of some test failures. It is updated now. |
#build |
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WrV_sC8JEe-0jrtdBgI-wg Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3b3b2648-d62f-4b66-af0a-0371e12943c0 Target locations of links might be accessible only to IBM employees. |
…se sentence case
…0 and dataContainer-1.0
The build njr-11-28816-20240620-1000 |
e4b76be
to
9f2b7ae
Compare
This PR would have been ready to merge but encountered merge conflicts due to the revert of #28786 |
#build |
fixes #28838 |
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_X8zNMC_dEe-0jrtdBgI-wg Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d24c91e1-540a-43eb-9e2a-0165a1a09f30 Target locations of links might be accessible only to IBM employees. |
Build request with run.packaging.verification=true: |
@@ -0,0 +1 @@ | |||
xJAVA_HOME=/Users/njr/drivers/jdk-21.jdk/Contents/Home |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was checked in accidentally since it contains a local dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting that. I have removed it here: bb73b30
#libby |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
The build njr-11-28816-20240621-1652 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_XI_RAC_lEe-0jrtdBgI-wg |
Latest RTC build encountered an infrastructure issue with the async BVT build, so I resubmitted it and it was successful. The only other failures are preexisting intermittent issues in the unrelated UI tests that don't even enable Jakarta Data. The packaging build did run this time (after manually overriding the property to ensure it does) and passed. |
The data-1.0 and dataContainer-1.0 features should be Jakarta EE 11 only.
Also, promote dataContainer-1.0 to beta.
Two tests had to be temporarily disabled due to a bug in persistence-3.2 with java.time.Instant attributes.