Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to EE 11 only and promote dataContainer-1.0 to beta #28816

Merged
merged 14 commits into from
Jun 22, 2024

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Jun 19, 2024

The data-1.0 and dataContainer-1.0 features should be Jakarta EE 11 only.
Also, promote dataContainer-1.0 to beta.
Two tests had to be temporarily disabled due to a bug in persistence-3.2 with java.time.Instant attributes.

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 19, 2024

#build

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LuY_oS5pEe-0jrtdBgI-wg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1cdd94ac-2fac-4caf-b37e-022741dc684f

Target locations of links might be accessible only to IBM employees.

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 19, 2024

The build failed. I forgot to update the Jakarta Data TCK bucket for EE 11. Trying again after updating...
#build
#libby

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/__WeQoC58Ee-0jrtdBgI-wg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=2228d286-599e-4e6a-84bb-0f1c4099b3de

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

@LibbyBot
Copy link

The build njr-11-28816-20240619-1456
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/__WeQoC58Ee-0jrtdBgI-wg
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=__WeQoC58Ee-0jrtdBgI-wg

@tevans78
Copy link
Member

Make sure that you update JakartaEE10Action to remove data-1.0 and check the EE Compatibility tests for anything special they might do.

@njr-11 njr-11 force-pushed the 28661-remove-toleration-of-ee10 branch from 46e8c08 to e4b76be Compare June 20, 2024 14:13
@njr-11
Copy link
Contributor Author

njr-11 commented Jun 20, 2024

Make sure that you update JakartaEE10Action to remove data-1.0 and check the EE Compatibility tests for anything special they might do.

Thanks, I missed that and it turned out to be the cause of some test failures. It is updated now.

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 20, 2024

#build
#libby

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WrV_sC8JEe-0jrtdBgI-wg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3b3b2648-d62f-4b66-af0a-0371e12943c0

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build njr-11-28816-20240620-1000
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WrV_sC8JEe-0jrtdBgI-wg
completed successfully!

@njr-11 njr-11 force-pushed the 28661-remove-toleration-of-ee10 branch from e4b76be to 9f2b7ae Compare June 21, 2024 15:38
@njr-11
Copy link
Contributor Author

njr-11 commented Jun 21, 2024

This PR would have been ready to merge but encountered merge conflicts due to the revert of #28786
To resolve this, I'm adding all of those commits and fixing the issue there, which was that a separate packaging build wanted to see metatype properties files for all languages without translated content.

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 21, 2024

#build
#libby

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 21, 2024

fixes #28838

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_X8zNMC_dEe-0jrtdBgI-wg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d24c91e1-540a-43eb-9e2a-0165a1a09f30

Target locations of links might be accessible only to IBM employees.

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 21, 2024

@@ -0,0 +1 @@
xJAVA_HOME=/Users/njr/drivers/jdk-21.jdk/Contents/Home
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was checked in accidentally since it contains a local dir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that. I have removed it here: bb73b30

@LibbyBot
Copy link

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 21, 2024

#libby
New build with run.packaging.verification=true after making review comment fix:
https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_XI_RAC_lEe-0jrtdBgI-wg

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 26 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 4 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 23 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 15 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_hu.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_cs.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_de.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_ko.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_ro.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_ru.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_fr.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_pl.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_pt_BR.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_zh_TW.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_zh.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_it.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_ja.properties

  • dev/io.openliberty.data.internal.persistence/resources/OSGI-INF/l10n/metatype_es.properties

@LibbyBot
Copy link

The build njr-11-28816-20240621-1652
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_XI_RAC_lEe-0jrtdBgI-wg
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_XI_RAC_lEe-0jrtdBgI-wg

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 22, 2024

Latest RTC build encountered an infrastructure issue with the async BVT build, so I resubmitted it and it was successful. The only other failures are preexisting intermittent issues in the unrelated UI tests that don't even enable Jakarta Data. The packaging build did run this time (after manually overriding the property to ensure it does) and passed.

@njr-11 njr-11 merged commit ef52faf into OpenLiberty:integration Jun 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants