per server validateApps #30199
per server validateApps #30199
Conversation
benjamin-confino
force-pushed
the
30198-liberty-server-app-validation
branch
3 times, most recently
from
437e588
to
2a9f454
Compare
|
#build |
|
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=60d219a0-01db-43db-b355-9f79e478847e Target locations of links might be accessible only to IBM employees. |
| public boolean getValidateApps() { | ||
| //orElse(false) because even if you change DEFAULT_VALIDATE_APPS that would be after | ||
| //validateAppsGlobal went through its static assignment, which used to be to the static | ||
| //value of DEFAULT_VALIDATE_APPS; which is true | ||
| return validateAppsGlobal.orElse(true); | ||
| } |
There was a problem hiding this comment.
DEFAULT_VALIDATE_APPS is final, so it's safe to use it here and assume it hasn't changed.
| //This gets the value of validateAppsGlobal, or if nothing was explicitly set it returns what would have been the value | ||
| //under the previous code where validateApps was a static variable shared across all servers | ||
| @Deprecated | ||
| public boolean getValidateApps() { |
There was a problem hiding this comment.
I think I would make this a simpler getter for validateAppsGlobal
| /* | ||
| * This method and its getter will change the validate apps setting for all servers, even ones running on other tests | ||
| * use setValidateAppsLocal to configure the setting for just the current server. | ||
| */ | ||
| @Deprecated | ||
| public static void setValidateApps(boolean validateApp) { |
There was a problem hiding this comment.
We should make this proper Javadoc and direct users to the correct method. Similarly for getValidateApps()
| /* | |
| * This method and its getter will change the validate apps setting for all servers, even ones running on other tests | |
| * use setValidateAppsLocal to configure the setting for just the current server. | |
| */ | |
| @Deprecated | |
| public static void setValidateApps(boolean validateApp) { | |
| /** | |
| * Sets the global flag to control whether to check that deployed apps started successfully when the server starts. | |
| * @param validateApp the value to set the flag to | |
| * | |
| * @deprecated use {@link #setValidateAppsLocal(boolean)} instead | |
| */ | |
| @Deprecated | |
| public static void setValidateApps(boolean validateApp) { |
benjamin-confino
force-pushed
the
30198-liberty-server-app-validation
branch
from
2a9f454
to
e4417e5
Compare
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
#build |
|
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1356882b-fc00-4747-a464-2984ccb79d17 Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_xN-AgKOOEe-kGLEyqlUFUA Target locations of links might be accessible only to IBM employees. |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_owPXgaOUEe-kGLEyqlUFUA Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_XxBtoaPyEe-kGLEyqlUFUA Target locations of links might be accessible only to IBM employees. |
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).fixes #30198
Deprecates methods on LibertyServer that make validateApps global, and introduce new methods that are perServer.