Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set JAVA_HOME correctly #30430

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

Set JAVA_HOME correctly #30430

wants to merge 1 commit into from

Conversation

jimblye
Copy link
Member

@jimblye jimblye commented Dec 17, 2024 •
edited
Loading

Alternatives:

  • Add a warning about performance when it falls into the last resort of invoking java to get the java.home property
  • Instead of invoking java, just display an error message and exit. Though, that probably wouldn't please the author of the stackoverflow question who has a custom java command script, that dynamically selects a version of java

@jimblye jimblye self-assigned this Dec 17, 2024
@jimblye jimblye force-pushed the JAVA_HOME-set-incorrectly-in-some-situations branch from b7cf23e to f0aaedd Compare December 17, 2024 16:32
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@wraschke
Copy link
Member

wraschke commented Dec 18, 2024 •
edited by LibbyBot
Loading

Please ignore this comment and any resulting pipelines.
(view Open Liberty Delivery Requirements Verification - ❌ completed with errors/failures.)

#libby

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

DHE Server Artifacts Check:

✔️ Your oss_ibm.maven GAV artifacts are on the DHE server. Thank you. ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimblye jimblye

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JAVA_HOME set incorrectly in some situations
3 participants
@jimblye @LibbyBot @wraschke