fix: skip testFindAndDeleteWithOrderBy using OrderBy on Oracle #30443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switching this PR to draft. Might be resolved by #30426 |
njr-11
reviewed
Dec 19, 2024
| @@ -1988,6 +1988,7 @@ public void testFindAndDeleteReturnsObjects() { | |||
| * OrderBy annotation. | |||
| */ | |||
| @Test | |||
| @SkipIfSysProp(DB_Oracle) //TODO Eclipse link SQL Generation bug on Oracle: https://github.com/OpenLiberty/open-liberty/issues/28545 | |||
There was a problem hiding this comment.
28545 was recently fixed. We will need to replace 28545 with a new issue number for different EclipseLink bug, once opened...
njr-11
reviewed
Dec 19, 2024
| @@ -1988,6 +1988,7 @@ public void testFindAndDeleteReturnsObjects() { | |||
| * OrderBy annotation. | |||
| */ | |||
| @Test | |||
| @SkipIfSysProp(DB_Oracle) //TODO Eclipse link SQL Generation bug on Oracle: https://github.com/OpenLiberty/open-liberty/issues/28545 | |||
There was a problem hiding this comment.
New issue 30444 is probably the one you want here:
Suggested change
| @SkipIfSysProp(DB_Oracle) //TODO Eclipse link SQL Generation bug on Oracle: https://github.com/OpenLiberty/open-liberty/issues/28545 | |
| @SkipIfSysProp(DB_Oracle) //TODO Eclipse link SQL Generation bug on Oracle: https://github.com/OpenLiberty/open-liberty/issues/30444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Known issue #28545