-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supressing warning messages on Netty deprecated Handler object #30456
Merged
mrsaldana
merged 2 commits into
OpenLiberty:netty-transport-http
from
mrsaldana:netty-transport-http-logging-read-supressWarning
Dec 30, 2024
Merged
Supressing warning messages on Netty deprecated Handler object #30456
mrsaldana
merged 2 commits into
OpenLiberty:netty-transport-http
from
mrsaldana:netty-transport-http-logging-read-supressWarning
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacrivriv
previously approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working on this!
mrsaldana
force-pushed
the
netty-transport-http-logging-read-supressWarning
branch
2 times, most recently
from
December 23, 2024 19:21
f86d319
to
8d9bb68
Compare
isaacrivriv
previously approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mrsaldana
force-pushed
the
netty-transport-http-logging-read-supressWarning
branch
from
December 29, 2024 15:43
8d9bb68
to
725d72d
Compare
pnicolucci
reviewed
Dec 30, 2024
dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/HttpPipelineInitializer.java
Show resolved
Hide resolved
pnicolucci
reviewed
Dec 30, 2024
...ibm.ws.transport.http/src/io/openliberty/http/netty/channel/LoggingRecvByteBufAllocator.java
Outdated
Show resolved
Hide resolved
pnicolucci
reviewed
Dec 30, 2024
...ibm.ws.transport.http/src/io/openliberty/http/netty/channel/LoggingRecvByteBufAllocator.java
Show resolved
Hide resolved
pnicolucci
approved these changes
Dec 30, 2024
mrsaldana
deleted the
netty-transport-http-logging-read-supressWarning
branch
December 30, 2024 15:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).