Skip to content

Simplify the apt install #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Simplify the apt install #304

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f0f3b8
Simplify the apt install
peternewman Mar 6, 2023
f0b47ae
Merge branch 'master' into peternewman-github-actions
peternewman Mar 6, 2023
c2ce5be
Try again to install Codespell from Git
peternewman Mar 6, 2023
07b2345
Run apt-get update as root
peternewman Mar 6, 2023
0e7cb60
Do more stuff as root
peternewman Mar 6, 2023
19bb76f
Merge branch 'master' into peternewman-github-actions
peternewman Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
#spellintian, nosetests, karma, lint, closure-compiler,
steps:
- uses: actions/checkout@master
- name: Update package database
run: sudo apt-get update -y
- name: Install dependencies
env:
TASK: ${{ matrix.task }}
Expand All @@ -21,12 +23,10 @@ jobs:
if [ "$TASK" = "flake8" -o "$TASK" = "flake8-wip" ]; then pip install flake8; fi
# If this causes SSL errors, then Sourceforge is probably in disaster recovery mode and needing Javascript. Could switch to a specific mirror, e.g. kent.dl.sourceforge.net
if [ "$TASK" = "pychecker" -o "$TASK" = "pychecker-wip" ]; then pip install http://sourceforge.net/projects/pychecker/files/pychecker/0.8.19/pychecker-0.8.19.tar.gz/download; fi
#if [ "$TASK" = "codespell" ]; then pip install git+https://github.com/codespell-project/codespell.git; fi
if [ "$TASK" = "codespell" ]; then pip install codespell; fi
sudo apt-get install xvfb
sudo apt-get install libhtml-parser-perl
sudo apt-get install lintian
sudo apt-get install moreutils
if [ "$TASK" = "codespell" ]; then sudo apt-get -y install python3-pip git; fi
if [ "$TASK" = "codespell" ]; then python3 -m pip install --no-input git+https://github.com/codespell-project/codespell.git; fi
#if [ "$TASK" = "codespell" ]; then pip install codespell; fi
sudo apt-get install -y xvfb libhtml-parser-perl lintian moreutils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this in one line makes the diff less readable in the future, should packages removed or added. However, one apt install command per line is also not perfect.
Can we do:

apt install \
  xvfb \
  ... \
  ... \
  ...

?

- uses: codespell-project/codespell-problem-matcher@v1
- name: Test
env:
Expand Down
Loading