fix!: update log and data dirs for linux and windows #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yinan Qin <[email protected]>
Signed-off-by: Yinan Qin <[email protected]>
elysia-best
changed the title
Signed-off-by: Yinan Qin <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the data and log directory paths for Linux and Windows platforms to follow platform-specific conventions, replacing the previous generic approach.
- Implements platform-specific data directory paths using XDG Base Directory specification for Linux and APPDATA for Windows
- Updates log directory resolution to use the new platform-specific data directories
- Consolidates directory logic by removing platform-specific branches in favor of unified data directory usage
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
elysia-best
changed the title
cxw620
reviewed
Sep 18, 2025
cxw620
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #107
may also fix #74
BREAKING CHANGE: data dir changed. Users may need to move the data dir manually.