Addition of Fuselage Engine Modeling #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with only fuselage engines
|
Corrections made to fix failure of "test_wing_detailed.py:DetailedWingBendingTest.test_case_multiengine" |
…1/Aviary into only_fuse_eng_final
| if num_wing_engines[i] > 0: | ||
| delme[loc[-1]] = engine_locations[idx:idx2][0] - \ | ||
| integration_stations[loc[-1]] | ||
| else: |
There was a problem hiding this comment.
Probably don't need the "else" branch anymore, since num_wing_engines=0 bails before it reaches this code now.
jkirk5
requested changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit increases Aviary's (version: 0.9.4-dev) functionality by adding statements to allow of the modeling of aircraft that only utilize fuselage engines. Previously modeling aircraft that only use fuselage mounted engines was not supported. This addition was checked with models that have no wing engines (2 fuselage engines), 2 wing engines (no fuselage engines), and 4 wing engines (no fuselage engines) and all optimized successfully. Before and after edit images attached.
Related Issues
Backwards incompatibilities
None
New Dependencies
None