Addition of global_throttle flag to variable hierarchy #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybrid global throttle now properly an option
…into engine_options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the previously hidden option to toggle if EngineDecks used a global throttle range across the entire data set, or disable it to normalize the throttle per flight condition (the default).
GASP-converted input files have global_throttle set to True, as GASP-based engine decks have varied throttle ranges and do not produce matching results if throttle is normalized per flight condition.
Will route this to 0.9.6.dev branch once reviews are in and it is still passing testing
Related Issues
Backwards incompatibilities
None
New Dependencies
None