POEM 097 Implementation, Part 1 #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne the hierarchy of the problem tree.
…to reports directory by default.
…ysis errors tests that were checking for optimizer result files in wrong locations
…ystem test problem name to compensate for now.
…n_outputs_dir2
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
naylor-b
reviewed
Jun 26, 2024
| @@ -26,7 +26,7 @@ | |||
| 'PSQP', # fails nominal with: (4) Maximum constraint value is less than or equal to tolerance | |||
| } | |||
|
|
|||
| @use_tempdirs | |||
| # @use_tempdirs | |||
There was a problem hiding this comment.
was commenting this out meant to be temporary?
naylor-b
approved these changes
Jun 26, 2024
…n_outputs_dir2
swryan
approved these changes
Jul 1, 2024
…n_outputs_dir2
hschilling
approved these changes
Jul 16, 2024
robfalck
added
the
backwards_incompatible
…n_outputs_dir2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This POEM begins the reorganization of problem output files for POEM 097.
Related Issues
Backwards incompatibilities
The global
_reports_dirvariable is removed, along with associated functions (set_reports_dir, reset_reports_dir).Reports may not be generated pre-setup, as the path to the reports directory is not known until setup time.
problem_setup_stack is removed in favor of a parent/child hierarchy for problems.
New Dependencies
None