Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specifying a parameter shape of None (to be determined via introspection) fails. #971

Closed
robfalck opened this issue Aug 24, 2023 · 1 comment · Fixed by #970
Closed

Explicitly specifying a parameter shape of None (to be determined via introspection) fails. #971

robfalck opened this issue Aug 24, 2023 · 1 comment · Fixed by #970
Assignees
@robfalck
Labels
bug Something isn't working

Comments

@robfalck
Copy link
Contributor

Description

The previous parameter introspection update causes a failure when the user gives the shape of a parameter as None.
In this case, dymos will use introspection to determine the shape, but the ParameterOptionsDictionary isn't allowing that as a valid value.

Example

add_parameter('g', shape=None, val=9.81, units='m/s**2') will now fail.

Dymos Version

1.8.1-dev

Relevant environment information

No response
@robfalck robfalck added the bug Something isn't working label Aug 24, 2023
@robfalck robfalck self-assigned this Aug 24, 2023
@robfalck robfalck mentioned this issue Aug 25, 2023
Merged
@robfalck
Copy link
Contributor Author

Closed by #970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robfalck robfalck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow parameter shape to be given as None, rather than just _unspecified robfalck/dymos
1 participant
@robfalck