Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parameter shape to be given as None, rather than just _unspecified #970

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

robfalck
Copy link
Contributor

@robfalck robfalck commented Aug 24, 2023

Summary

The previous parameter introspection update changed parameters so that a shape of None is not allowed. This is added back in as dymos can handle this situation just fine.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@coveralls
Copy link

Coverage Status

coverage: 92.674%. remained the same when pulling c5936c1 on robfalck:allow_param_shape_none into 1ee9741 on OpenMDAO:master.

@robfalck robfalck merged commit b7e4cef into OpenMDAO:master Aug 25, 2023
8 checks passed
@robfalck robfalck deleted the allow_param_shape_none branch August 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly specifying a parameter shape of None (to be determined via introspection) fails.
3 participants