Support zero byte value #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brief Changes:
==============
* Included null check on data pointer only when data length is
not zero
* Updated comments explaining relevant changes
Testing Done:
=============
* Manual testing with nvk_test_cli
Signed-off-by: r.kavuluru <[email protected]>
[SPDK_TCP-NVMF/KVTRANS] Support zero byte value on target
…port-zero-byte-value
|
Looks good to me. |
|
benixon
approved these changes
Aug 12, 2024
| @@ -764,7 +764,7 @@ nkv_result nkv_retrieve_kvp (uint64_t nkv_handle, nkv_io_context* ioctx, const n | |||
| smg_info(logger, "NKV retrieve operation is successful for nkv_handle = %u, key = %s, key_length = %u, supplied length = %u, actual length = %u", | |||
| nkv_handle, key ? (char*)key->key: "NULL", key ? key->length:0, value->length, value->actual_length); | |||
| if (value->actual_length == 0) | |||
| smg_error(logger, "NKV retrieve operation returned 0 value length object !!, nkv_handle = %u, key = %s, key_length = %u, supplied length = %u, actual length = %u", | |||
| smg_warn(logger, "NKV retrieve operation returned 0 value length object !!, nkv_handle = %u, key = %s, key_length = %u, supplied length = %u, actual length = %u", | |||
There was a problem hiding this comment.
It would be better if this is debug log, if we are going to see this more frequently in the IO path.
| @@ -1031,7 +1041,7 @@ nkv_result NKVTargetPath::do_retrieve_io_from_path(const nkv_key* n_key, const n | |||
| int ret = kvs_retrieve_tuple(path_cont_handle, &kvskey, &kvsvalue, &ret_ctx); | |||
| if(ret != KVS_SUCCESS ) { | |||
| if (ret != KVS_ERR_KEY_NOT_EXIST) { | |||
| smg_error(logger, "Retrieve tuple failed with error 0x%x - %s, key = %s, dev_path = %s, ip = %s", | |||
| smg_warn(logger, "Retrieve tuple failed with error 0x%x - %s, key = %s, dev_path = %s, ip = %s", | |||
There was a problem hiding this comment.
Why is this warning? This should still be error I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is for supporting zero byte value in the KV pair. Tools like IO500 first create file with empty/zero byte value in it and we need this zero byte value support within DSS for that. We had checks in multiple layers within dss-sdk stack to protect against zero byte value earlier. As part of this MR, we needed to modify code on those parts to gracefully handle zero byte value.
: Somnath Roy, [email protected]