Address Windows thread server re-entrant queue bug #4582 #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
added a commit
to tylerjereddy/openblas-libs
that referenced
this pull request
Mar 30, 2024
* Note that this PR is against the `scipy` feature branch and not the `main` branch because it is intended to provide new OpenBLAS binaries for SciPy, but in the old non-wheel format (we're not ready for the new wheel format just yet). * The specific motivation for needing these new OpenBLAS binaries is discussed at this SciPy issue: scipy/scipy#20294 * In the above issue one of the lead OpenBLAS developers informally suggests it should be "ok" to build off their `develop` branch at this new hash given the merging of OpenMathLib/OpenBLAS#4587 to prevent a Windows hang for `scikit-learn`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to fix lost work in case of re-entrant calls to
exec_blas_async(). This is intended to fix scipy/scipy#20294