Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for Python 3.12. In earlier versions, the Python bindings did not properly acquire the Global Interpreter Lock (GIL) when returning Python objects, particularly around the
GetPrivateKeyBytes
pybind11 definitions. Since we are returning apy::bytes
object, we should have been acquiring the GIL, but instead, we were incorrectly releasing it.In previous versions, this behavior could lead to undefined behavior or potential crashes when Python objects were accessed without the GIL being held (although in practice this was not observed). The refactor ensures thread safety by retaining scoped GIL release calls while now correctly acquiring the lock when exceptions are raised back to Python. This improves consistency and correctness when interacting with Python objects.
Also updates the rustc version to the latest (
v1.81.0
) and PCJ latest changes (removed unused bazel configuration for GRPC)Affected Dependencies
N/A
How has this been tested?
test_3_12
bazel test which is now included in CI workflowChecklist