Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SRMD validation and schema support #1417

Open
wants to merge 24 commits into
base: maintenance/v2.1
Choose a base branch
from
Open

Add SRMD validation and schema support #1417

wants to merge 24 commits into from

Conversation

just-amin
Copy link

Pull Request: Add SRMD Schema Validation to OMSimulator

Description

This pull request addresses #1408 by introducing validation for SRMD files (.srmd) against the SSP Traceability Schema. Validation is performed during import and addResource operations.

Key Changes

  1. SRMD Validation:

    • Extended the existing XML validation framework to support .srmd files.
    • Integrated SimulationResourceMetaData.xsd schema for SRMD validation.

  2. Schema Updates:

    • Replaced xs:dateTimeStamp with a custom dateTimeStampType in SSPTraceabilityCommon.xsd for compatibility with XML Schema 1.0.

  3. Testing:

    • Added invalidSRMD.py to test:
      • Validation of model contains SRMD file that @robha67 provides in here

Related Issue

Closes #1408.

@just-amin just-amin requested review from adrpo and arun3688 January 10, 2025 12:05
@just-amin just-amin self-assigned this Jan 10, 2025
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@arun3688 arun3688 requested a review from lochel January 10, 2025 12:14
@arun3688
Copy link
Contributor

@just-amin add the tests to the resources and also to Makefile

adrpo
adrpo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@adrpo adrpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

arun3688 and others added 15 commits January 16, 2025 13:42
@arun3688
add test to Makefile
ff2630a
@just-amin
add invalidSRMD target to Makefile
60330ff
@arun3688
add testsuite/validate/validateSRMD.lua
7cd8300
@just-amin
update validateSRMD tests to include Lua script and adjust error hand…
16fd25c 
…ling
@just-amin
update teardown commands in validateSRMD tests
fe580b7
@just-amin
add validate.log target to Makefile for validation tests
a970ad5
@just-amin
remove unnecessary model deletion in validateSRMD.py
a471479
@just-amin
fix: correct warning message formatting in validateSSD.py
e62637e
@arun3688
return as warning when SRMD validation failed
0902b92 
 - use relative path to satisfy jenkins
 - fix tests
@just-amin
update SRMD validation error messages
323e2b4
@just-amin
update SRMD validation output for
7f2f708
@arun3688
fix test
de588d3
@arun3688
fix path
8de4a62
@just-amin
update SRMD validation output and warnings in test scripts
f987790
@just-amin
update validation output formatting in SRMD test script
bf17b44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arun3688 arun3688 arun3688 left review comments

@adrpo adrpo adrpo approved these changes

@lochel lochel Awaiting requested review from lochel

Assignees

@just-amin just-amin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@just-amin @CLAassistant @arun3688 @adrpo