Goto declaration #26
Merged
Goto declaration #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evan Hedbor <[email protected]>
Co-authored-by: Evan Hedbor <[email protected]>
- Adding copyright - Updating README to showecase goto-declaration - Fixing ModelicaLibrary to work for e.g. "path/to/Modelica 4.0.0+main.om"
AnHeuermann
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
When testing a few declarations in some Modelica libraries like NeuralNetwork the goto function works fine. When testing the Modelica standard library it doesn't work for me. Looks like my save location of the MSL contains a space in the path ~/.openmodelica/libraries/Modelica\ 4.0.0+maint.om. When moving the directory to some location without a space it works as expected.
@ehedbor @PaddiM8 I added a commit to fix this.
Now goto-declaration is working as expected. For sure there are some bugs left but they can be fixed when they pop up. When you are happy with the PR (and my change) the PR can be merged.
|
Nice! We are both happy with it |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the textDocument/gotoDeclaration LSP feature.