fix(app): Display raw HTML in markdown instead of parsing to JSX

OpenNeuroOrg · Jan 24, 2024 · bb875a5 · bb875a5
1 parent 4c189c8
commit bb875a5
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 6 deletions.
diff --git a/packages/openneuro-app/src/scripts/dataset/components/MetaDataBlock.tsx b/packages/openneuro-app/src/scripts/dataset/components/MetaDataBlock.tsx
@@ -1,4 +1,3 @@
-import Markdown from "markdown-to-jsx"
 import React from "react"
 
 export interface MetaDataBlockProps {

diff --git a/packages/openneuro-app/src/scripts/dataset/draft-container.tsx b/packages/openneuro-app/src/scripts/dataset/draft-container.tsx
@@ -311,7 +311,9 @@ const DraftContainer: React.FC<DraftContainerProps> = ({ dataset }) => {
                     description={description.Acknowledgements}
                     editMode={hasEdit}
                   >
-                    <Markdown>{description.Acknowledgements || "N/A"}</Markdown>
+                    <Markdown options={{ disableParsingRawHTML: true }}>
+                      {description.Acknowledgements || "N/A"}
+                    </Markdown>
                   </EditDescriptionField>
                 )}
               />
@@ -326,7 +328,9 @@ const DraftContainer: React.FC<DraftContainerProps> = ({ dataset }) => {
                     description={description.HowToAcknowledge}
                     editMode={hasEdit}
                   >
-                    <Markdown>{description.HowToAcknowledge || "N/A"}</Markdown>
+                    <Markdown options={{ disableParsingRawHTML: true }}>
+                      {description.HowToAcknowledge || "N/A"}
+                    </Markdown>
                   </EditDescriptionField>
                 )}
               />

diff --git a/packages/openneuro-app/src/scripts/dataset/fragments/edit-description-list.jsx b/packages/openneuro-app/src/scripts/dataset/fragments/edit-description-list.jsx
@@ -46,7 +46,9 @@ const EditDescriptionList = ({
         <ul>
           {children.map((item, index) => (
             <li key={index}>
-              <Markdown>{item}</Markdown>
+              <Markdown options={{ disableParsingRawHTML: true }}>
+                {item}
+              </Markdown>
             </li>
           ))}
         </ul>

diff --git a/packages/openneuro-app/src/scripts/dataset/routes/dataset-default.tsx b/packages/openneuro-app/src/scripts/dataset/routes/dataset-default.tsx
@@ -28,7 +28,9 @@ export const DatasetDefault = ({ dataset, hasEdit }) => (
             expandLabel="Read More"
             collapseLabel="Collapse"
           >
-            <Markdown>{dataset.draft.readme || "N/A"}</Markdown>
+            <Markdown options={{ disableParsingRawHTML: true }}>
+              {dataset.draft.readme || "N/A"}
+            </Markdown>
           </ReadMore>
         </EditDescriptionField>
       )}

diff --git a/packages/openneuro-app/src/scripts/dataset/routes/snapshot-default.tsx b/packages/openneuro-app/src/scripts/dataset/routes/snapshot-default.tsx
@@ -14,7 +14,7 @@ export const SnapshotDefault = ({ dataset, snapshot }) => (
       heading="README"
       item={
         <ReadMore id="readme" expandLabel="Read More" collapseLabel="Collapse">
-          <Markdown>
+          <Markdown options={{ disableParsingRawHTML: true }}>
             {snapshot.readme == null ? "N/A" : snapshot.readme}
           </Markdown>
         </ReadMore>