Improve handling of file requests during worker restarts #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually caused by the worker upgrading or migrating nodes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2960 +/- ##
=======================================
Coverage 64.91% 64.91%
=======================================
Files 378 378
Lines 24317 24322 +5
Branches 878 878
=======================================
+ Hits 15785 15789 +4
- Misses 8532 8533 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids an API crash and returns an error the clients can handle if a worker is temporarily unavailable (took more than 10 seconds begin responding to the file request). Timeout might be a little tight here for some datasets but raising it too much leads to stacking up these errors while a worker restarts.
Handling the timeout error here in both the standard way and the Node.js way to keep this portable for Deno.