Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search indexing for dataset_description DatasetType field #3035

Merged
merged 4 commits into from
May 2, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Apr 29, 2024

Defaults to raw if unspecified by the dataset. Any string is allowed here for future BEPS extending this field if needed.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 42.50%. Comparing base (059e3b5) to head (589a8b1).

Files Patch % Lines
...ckages/openneuro-server/src/datalad/description.ts 50.00% 3 Missing ⚠️
packages/openneuro-server/src/graphql/schema.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3035   +/-   ##
=======================================
  Coverage   42.50%   42.50%           
=======================================
  Files         600      600           
  Lines       37906    37915    +9     
  Branches     1111     1113    +2     
=======================================
+ Hits        16112    16116    +4     
- Misses      21578    21583    +5     
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 7229e71 into master May 2, 2024
11 checks passed
@nellh nellh deleted the dataset-type-search branch May 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant