Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Implement search facets for DatasetType field #3036

Merged
merged 2 commits into from
May 2, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Apr 29, 2024

Adds a dataset type selection to the search UI.

image

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 29.09091% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 42.48%. Comparing base (059e3b5) to head (5523972).
Report is 5 commits behind head on master.

Files Patch % Lines
.../src/scripts/search/inputs/dataset-type-select.tsx 24.24% 25 Missing ⚠️
...nneuro-components/src/search-page/FiltersBlock.tsx 8.33% 11 Missing ⚠️
...neuro-app/src/scripts/search/search-params-ctx.tsx 0.00% 2 Missing ⚠️
...nneuro-app/src/scripts/search/search-container.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
- Coverage   42.50%   42.48%   -0.03%     
==========================================
  Files         600      601       +1     
  Lines       37906    37969      +63     
  Branches     1111     1113       +2     
==========================================
+ Hits        16112    16131      +19     
- Misses      21578    21622      +44     
  Partials      216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit b093dd6 into master May 2, 2024
9 of 11 checks passed
@nellh nellh deleted the derivatives-search-ui branch May 2, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant