Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting refactor and enable GitHub actions #3179

Merged
merged 23 commits into from
Oct 24, 2024
+2,579 −2,031

ci: Add ESLint step

dc70912
Select commit
Loading
Failed to load commit list.
Merged

Linting refactor and enable GitHub actions #3179

ci: Add ESLint step
dc70912
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 23, 2024 in 0s

43.09% (+0.24%) compared to 0bf65b0

View this Pull Request on Codecov

43.09% (+0.24%) compared to 0bf65b0

Details

Codecov Report

Attention: Patch coverage is 56.55577% with 222 lines in your changes missing coverage. Please review.

Project coverage is 43.09%. Comparing base (0bf65b0) to head (dc70912).

Files with missing lines Patch % Lines
packages/openneuro-cli/src/download.js 3.70% 26 Missing ⚠️
...euro-app/src/scripts/pages/admin/flagged-files.jsx 0.00% 18 Missing ⚠️
packages/openneuro-client/src/client.js 11.76% 15 Missing ⚠️
...ts/dataset/mutations/delete-anonymous-reviewer.tsx 0.00% 8 Missing and 1 partial ⚠️
packages/openneuro-server/src/handlers/comments.ts 0.00% 7 Missing ⚠️
...cripts/dataset/files/viewers/file-viewer-nifti.tsx 0.00% 5 Missing ⚠️
...src/scripts/dataset/fragments/copyable-tooltip.jsx 0.00% 4 Missing and 1 partial ⚠️
.../openneuro-server/src/graphql/resolvers/dataset.ts 16.66% 5 Missing ⚠️
packages/openneuro-app/src/scripts/app.tsx 0.00% 3 Missing and 1 partial ⚠️
...-components/src/activity-slider/ActivitySlider.tsx 0.00% 4 Missing ⚠️
... and 78 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3179      +/-   ##
==========================================
+ Coverage   42.84%   43.09%   +0.24%     
==========================================
  Files         549      547       -2     
  Lines       36187    36163      -24     
  Branches     1132     1128       -4     
==========================================
+ Hits        15506    15584      +78     
+ Misses      20479    20379     -100     
+ Partials      202      200       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov