Allow sharing permissions by ORCID

[nellh]

Adds the option to add dataset permissions via ORCID.

Fixes #3190.

[codecov]

Codecov Report

Attention: Patch coverage is 51.42857% with 85 lines in your changes missing coverage. Please review.

Project coverage is 44.72%. Comparing base (0d7bdd7) to head (85ddbfc).
Report is 11 commits behind head on master.

Files with missing lines	Patch %	Lines
...nneuro-server/src/graphql/resolvers/permissions.ts	12.76%	41 Missing ⚠️
.../src/scripts/dataset/routes/manage-permissions.jsx	0.00%	32 Missing ⚠️
...openneuro-server/src/graphql/resolvers/mutation.ts	0.00%	6 Missing ⚠️
...c/scripts/dataset/mutations/update-permissions.tsx	96.47%	3 Missing ⚠️
packages/openneuro-server/src/graphql/schema.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3196      +/-   ##
==========================================
+ Coverage   44.45%   44.72%   +0.26%     
==========================================
  Files         592      590       -2     
  Lines       37861    37835      -26     
  Branches     1131     1138       +7     
==========================================
+ Hits        16830    16920      +90     
+ Misses      20831    20717     -114     
+ Partials      200      198       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thinknoack]

@nellh - I know you are updating a few tests so send this back when you have those.

in addition here is a small note, when removing perms, the client/ui doesn't update the state for visual feedback until a refresh.

After a confirmed removal

After refresh

[nellh]

in addition here is a small note, when removing perms, the client/ui doesn't update the state for visual feedback until a refresh.

Thanks! That's because the remove mutation has the same issue we discussed where the API should return the entire fragment it modifies (all permissions instead of just the user) to update the client cache. I think that's a good bug to note (#3198) now that this generally fixes the client state issues with adding/removing permissions.

[nellh]

@thinknoack Added the test case we discussed in 85ddbfc.

[thinknoack]

*Approving with small note

I have reviewed the code/file changes and tested with emails for both a new user and a original upload user. That all looks great.

*note - I will not be able to test the ORCID integration until I get my sandbox sorted out.