fix(app): Display pending validation when schema validator is running #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn't returned anything
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3215 +/- ##
==========================================
+ Coverage 45.42% 45.65% +0.22%
==========================================
Files 594 594
Lines 37993 37999 +6
Branches 1148 1161 +13
==========================================
+ Hits 17258 17348 +90
+ Misses 20538 20454 -84
Partials 197 197 ☔ View full report in Codecov by Sentry. |
nellh
force-pushed
the
no-validation-pending
branch
from
bde0189 to
31ad0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression found in 4.29.0-alpha.0. Validation would display "valid" while the schema validator was running instead of pending.