Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite config update #3227

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Vite config update #3227

merged 4 commits into from
Nov 19, 2024

Conversation

thinknoack
Copy link
Contributor

minor changes to docker-compose and vite.config

@thinknoack thinknoack requested a review from nellh November 19, 2024 20:35
@thinknoack thinknoack self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.66%. Comparing base (ae8103c) to head (e56253f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3227   +/-   ##
=======================================
  Coverage   45.65%   45.66%           
=======================================
  Files         594      595    +1     
  Lines       37999    38013   +14     
  Branches     1161     1167    +6     
=======================================
+ Hits        17348    17357    +9     
- Misses      20454    20459    +5     
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Comment on lines 36 to 37
volumes:
- ./:/srv:rw,z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
volumes:
- ./:/srv:rw,z

This should be redundant with the app config later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been removed

@@ -27,6 +27,10 @@ export default defineConfig({
port: 80,
host: "0.0.0.0",
cors: true,
watch: {
usePolling: true, // Enable polling for file watching
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a pretty significant performance cost if it isn't needed for a large project like this. Might be better to use these overrides on macOS and document it for developer setup instead.

In .env:

CHOKIDAR_USEPOLLING=true
CHOKIDAR_INTERVAL=1000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this from vite.config and added polling config to docker-compose and config.env

@nellh nellh merged commit 4a5bf01 into master Nov 19, 2024
13 checks passed
@nellh nellh deleted the vite-config-update branch November 19, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants