-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite config update #3227
Vite config update #3227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3227 +/- ##
=======================================
Coverage 45.65% 45.66%
=======================================
Files 594 595 +1
Lines 37999 38013 +14
Branches 1161 1167 +6
=======================================
+ Hits 17348 17357 +9
- Misses 20454 20459 +5
Partials 197 197 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
docker-compose.yml
Outdated
volumes: | ||
- ./:/srv:rw,z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
volumes: | |
- ./:/srv:rw,z |
This should be redundant with the app config later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been removed
@@ -27,6 +27,10 @@ export default defineConfig({ | |||
port: 80, | |||
host: "0.0.0.0", | |||
cors: true, | |||
watch: { | |||
usePolling: true, // Enable polling for file watching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a pretty significant performance cost if it isn't needed for a large project like this. Might be better to use these overrides on macOS and document it for developer setup instead.
In .env
:
CHOKIDAR_USEPOLLING=true
CHOKIDAR_INTERVAL=1000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this from vite.config and added polling config to docker-compose and config.env
…adme, and removing polling from vite config
minor changes to docker-compose and vite.config