fix(app): prevent unnecessary download of EDF/NWB data to browser #3230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently support for viewing EDF and NWB files was added by embedding a Neurosift iframe
#3187
However I recently noticed that when navigating to such a file, the entire content of the file gets downloaded to the browser before the view is rendered. This is unnecessary (and potentially very resource demanding) as neurosift handles efficient lazy-loading of the file without downloading the entire thing.
This PR solves the issue by conditionally skipping the fetch step in the case of these file extension types.
tag: @nellh