Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User routes #3242

Merged
merged 28 commits into from
Dec 19, 2024
Merged

User routes #3242

merged 28 commits into from
Dec 19, 2024

Conversation

thinknoack
Copy link
Contributor

No description provided.

@thinknoack thinknoack marked this pull request as draft December 2, 2024 20:29
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 89.59538% with 72 lines in your changes missing coverage. Please review.

Project coverage is 46.68%. Comparing base (8f78abb) to head (6624011).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
...uro-app/src/scripts/users/components/edit-list.tsx 19.48% 62 Missing ⚠️
.../src/scripts/users/components/editable-content.tsx 91.66% 5 Missing ⚠️
packages/openneuro-app/src/scripts/routes.tsx 0.00% 4 Missing ⚠️
...o-app/src/scripts/users/components/edit-string.tsx 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3242      +/-   ##
==========================================
+ Coverage   45.68%   46.68%   +1.00%     
==========================================
  Files         595      609      +14     
  Lines       38015    38698     +683     
  Branches     1171     1225      +54     
==========================================
+ Hits        17366    18066     +700     
+ Misses      20452    20437      -15     
+ Partials      197      195       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is on the right track. Added some suggestions but it's mostly minor fixes.

packages/openneuro-app/src/scripts/users/user-query.tsx Outdated Show resolved Hide resolved
packages/openneuro-app/src/scripts/routes.tsx Outdated Show resolved Hide resolved
packages/openneuro-app/src/scripts/users/user-routes.tsx Outdated Show resolved Hide resolved
packages/openneuro-app/src/scripts/users/user-routes.tsx Outdated Show resolved Hide resolved
packages/openneuro-app/src/scripts/users/user-routes.tsx Outdated Show resolved Hide resolved
packages/openneuro-app/src/scripts/users/user-query.tsx Outdated Show resolved Hide resolved
@thinknoack thinknoack marked this pull request as ready for review December 12, 2024 19:34
@thinknoack thinknoack changed the title Draft: User routes User routes Dec 16, 2024
@thinknoack
Copy link
Contributor Author

Looks like this is on the right track. Added some suggestions but it's mostly minor fixes.

ok, lint/ts issues have been resolved.

Copy link
Contributor

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor changes for the test filenames.

@thinknoack thinknoack merged commit 7cd560f into master Dec 19, 2024
13 checks passed
@thinknoack thinknoack deleted the user-routes branch December 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants