-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User routes #3242
User routes #3242
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3242 +/- ##
==========================================
+ Coverage 45.68% 46.68% +1.00%
==========================================
Files 595 609 +14
Lines 38015 38698 +683
Branches 1171 1225 +54
==========================================
+ Hits 17366 18066 +700
+ Misses 20452 20437 -15
+ Partials 197 195 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is on the right track. Added some suggestions but it's mostly minor fixes.
packages/openneuro-app/src/scripts/users/user-account-container.tsx
Outdated
Show resolved
Hide resolved
…ser props in user-container
ok, lint/ts issues have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor changes for the test filenames.
No description provided.