Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding workaround for elastic search container on mac #3268

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

thinknoack
Copy link
Contributor

No description provided.

@thinknoack thinknoack requested a review from nellh January 6, 2025 18:52
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.68%. Comparing base (4f20b62) to head (8abbeea).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3268   +/-   ##
=======================================
  Coverage   46.68%   46.68%           
=======================================
  Files         609      609           
  Lines       38701    38701           
  Branches     1225     1225           
=======================================
  Hits        18068    18068           
  Misses      20438    20438           
  Partials      195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh
Copy link
Contributor

nellh commented Jan 6, 2025

Testing this it does break on anything other than Apple Silicon, so this will need to be moved to the environment file.

@thinknoack
Copy link
Contributor Author

Testing this it does break on anything other than Apple Silicon, so this will need to be moved to the environment file.

I moved these to the config.env and updated the various files to correspond

@nellh nellh merged commit 2d92dda into master Jan 6, 2025
15 checks passed
@nellh nellh deleted the arm64-elasticsearch-compose-update branch January 6, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants