Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Show correct errors/warnings counts for schema validator #3270

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jan 8, 2025

Correctly show the error and warning counts in the validation drop down.

Fixes #3263.

Copy link

sentry-io bot commented Jan 8, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/openneuro-app/src/scripts/validation/validation.tsx

Function Unhandled Issue
Errors ReferenceError: warnings is not defined /datasets...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.69%. Comparing base (042ce9c) to head (b80d887).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
...penneuro-app/src/scripts/validation/validation.tsx 54.54% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3270   +/-   ##
=======================================
  Coverage   46.68%   46.69%           
=======================================
  Files         609      609           
  Lines       38701    38704    +3     
  Branches     1225     1225           
=======================================
+ Hits        18068    18071    +3     
  Misses      20438    20438           
  Partials      195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh requested a review from thinknoack January 10, 2025 18:40
Copy link
Contributor

@thinknoack thinknoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed local and ran tests. looks good.

@nellh nellh merged commit 72c9c01 into master Jan 10, 2025
15 checks passed
@nellh nellh deleted the 3263-validation-count-fixes branch January 10, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset page shows schema validator errors and warnings as "errors"
2 participants