Refactor codebase #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skchronicles
requested changes
Aug 2, 2024
skchronicles
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Everything looks good. @tovahmarkowitz did you have a chance to look over the outputs on biowulf?
skchronicles
approved these changes
Aug 7, 2024
Adding ending carriage return to output files
tovahmarkowitz
approved these changes
Aug 7, 2024
tovahmarkowitz
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the code base to make more interpretable and extendable.
This is a large review, with alot of moving around and cruft cleaning. I would take this a step further and rework some of the shell directives to be more streamlined and avoid some specific design patterns.