Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo "Hihlight" -> "Highlight" #66

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from

Conversation

Stefal
Copy link

@Stefal Stefal commented Feb 8, 2019

No description provided.

Copy link
Member

@zyioump zyioump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must generate the migrate script see README. And I don't think that we can merge it right know all software using virtualtour_highlight ressource will not work anymore (like opv-status or opv-tasks maybe). You must update the python client too.

@Stefal
Copy link
Author

Stefal commented Feb 12, 2019

I don't plan to apply this commit on a already running instance, so do i still have to migrate the database ?

I didn't find anything using virtualtour_highlight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants