Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orientation on marker #12

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Add orientation on marker #12

merged 1 commit into from
Sep 30, 2018

Conversation

zyioump
Copy link
Member

@zyioump zyioump commented Jul 26, 2018

No description provided.

@Benvii
Copy link
Member

Benvii commented Aug 11, 2018

Thanks.
Would be easier to check it if OpenPathView/OPV_Tasks#39 is closed. I'll try to investigate it tonight.

Otherwise if I don't have time I will simply manually modify compass value in database without using the image to check it.

@Benvii
Copy link
Member

Benvii commented Sep 30, 2018

It works but it's a bit difficult to understand where the point is really ... For instance :
works

I'm not sure if it's a good idea to have this feature.

Benvii
Benvii approved these changes Sep 30, 2018
View reviewed changes
Copy link
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge it we will remove it if it's not really usefull.

@Benvii Benvii merged commit 957c131 into master Sep 30, 2018
@zyioump zyioump deleted the marker-orientation branch October 20, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benvii Benvii Benvii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyioump @Benvii